Skip to content

Fix crit shrug for projectile & aoe

yutio888 requested to merge yutio888/t-engine4:fix_crit_shrug into master

Currently the ignore_direct_crits attr is not working very well with projectiles and talents hitting more than one targets. Critical status is stored in turn_procs, and when damage lands the status may get cleared already.

This merge request contains the following changes:

  1. Add critical state info in projectile, so it is bound to the projectile and can be properly handled. Besides, projectiles now display critical multiplier.
  2. Let aoe damage project share the same critical status.
  3. Add a new function critTable in Combat.lua that returns a detailed table of damage, critical info and some additional info.

Projectiles in dlcs may need a fix as well, but I have no access to the repos, and there needs someone with the access to fix them.

Merge request reports

Loading