Skip to content

Clone Effect Removal Adjustment

Ryan Yappert requested to merge RootOfAllThings/t-engine4:corrosiveWorm_fix into master

Inner Demons uniquely removes not only remove_on_clone tagged effects, but all detrimental timed effects. This causes a bug with Corrosive Worm as removing the worm causes it to detonate. The projection expects the actor's position to be defined, but effect removal is typically handled before the actor is placed, causing an error. This adjusts the order of Inner Demons to wait until the actor is placed to remove effects, and adjusts several other cloning effects (Shadow Simulacrum, Projection) to do the same for consistency (although these typically only remove flagged effects).

Also adjusts Corrosive Worm to not interact bizarrely with Inner Demons: Corrosive Worm resets to 0 stored damage when the clone is made, to prevent Inner Demons causing chain reaction bombing in an incredibly niche interaction.

This MR is save safe.

Merge request reports