Skip to content
Snippets Groups Projects

weapon_recurse bugfix

Merged Otowa Kotori requested to merge otowakotori/t-engine4:weapon_attack_recurse into master

This is the cause of an interaction between Flexible Combat and weapon attack_recurse that may cause infinite recursive attack

Cause of this problem:

Currently, recurse attack will not check if current weapon have attack_recurse property.

Also, this mechanism use self.__attacktargetwith_recursing = nil to mark attack recurse haven't been started / have been ended.

Flexible combat is triggered before recurse attack

So, a flexible combat unarmed attack can consume self.__attacktargetwith_recursing, while the later triggered attack thinking we are starting a new attack, recurse again.

You can test this with Flexible Combat + Razorlock.

This is a quick fix, howevr while considering while using the old if self.__attacktargetwith_recursing or (weapon and weapon.attack_recurse) then design may also need discussion.

Merge request reports

Merged by avatar (Jan 10, 2025 5:53am UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading