Skip to content
Snippets Groups Projects

WIP: fix misdirection

Open Tawny Harte requested to merge orange/t-engine4:1.6.7-misdirection-fix into master

very few effects define src (nb _is_actor should have been __is_actor)

Merge request reports

Approval is optional
Merge blocked: 1 check failed

Merge details

  • The source branch is 1628 commits behind the target branch.
  • 2 commits and 1 merge commit will be added to master.
  • Source branch will not be deleted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Would probably be a good change to add something on effect application to always define src (or mark it nil if the effect is environmental). Source is a generally useful property to have.

  • Tawny Harte Added 1 commit:

    Added 1 commit:

    • eef4144f - misdirection doesn't redirect crosstiers
  • Author Contributor

    I agree. This is a thought I've had on the back burner for a while now; I've not really been able to think of an elegant approach. I'd probably not define src as nil if the effect was environmental as the src table should contain enough info to differentiate between source types.

Please register or sign in to reply
Loading