Summoner Tweaks

General cleanup and polishing of Summoner talents without much use or with too limited of a use case. The goal is to make summoner more enjoyable to play overall while maintaining their current core gameplay experience.

Rage:
•Changed to be a passive callbackOnSummonDeath instead of an active. It wasn't worth using at all before. It's still on the weaker side as a talent now, but at least now it's a passive and will do something

Detonate:
•Slightly improved code structuring
•Added numbers for what it does to its tooltip
•Replaced or expanded most effects and adjusted scaling to be overall more useful
°The intent was to provide a selection of various buffs and debuffs that will be of varying use depending on the situation--they are overall strong (and thus the long cooldown) and create a competitive decision of what summon you want to detonate

Resilience:
•Changed to be more straightforward
°+Con -> +percent max life
°Adding effective talent level to determine summon duration -> directly increasing summon duration
•Buffed in general--the amount of Con it gave before was insignificant and stayed static through the game, and it rarely gave more than 1 turn to summon duration. The life bonus can now be meaningful and not fall off to insignificance as the player levels, and the duration increase is less opaque and more relevant

Summon Control:
•Replaced entirely and renamed to Pheromones. Swapping control to summons encourages tedious gameplay and was of limited utility in general
•Now an instant use active that can be used to mark a target for your summons to focus on

Grand Arrival:
•Slightly improved code structuring
•Added numbers for what it does to its tooltip

Wild Summon:
•Replaced effects for ritch flamespitter, rimebark, hydra, golem, and jelly to be more useful and allow more synergy between summons

Misc Changes:
•Removed Combat Veteran from summoner. This category was not worth unlocking, nor did it fit thematically in the first place
•Made Nature's Cycle lower the cooldown of Summon Control instead of Rage
•Bugfix for Frantic Summoning's duration decrementing due to non-nature summons and fire drake hatchling grand arrival summons
•Removed Heal on Nature Summon as a randart property. Summoner is the only class in the game it benefits, and it is very strong to stack
•Adjusted caller's ego to be more useful to summoner

Added 68 commits:

• da930f1a...746bc751 - 24 commits from branch tome:master
• 7b659589 - Rework Summon Control
• 3010d5b4 - Rework Summon Control
• 516501cb - Rework Summon Control
• d9289168 - Revert "Rework Summon Control"
• 1fbc0c5a - Revert "Rework Summon Control"
• 2aafc526 - Revert "Rework Summon Control"
• 9f8ecfcc - Merge https://git.net-core.org/tome/t-engine4
• 00b0291b - Remove heal on nature summon from randart properties
• 737f65f1 - Improve structuring of Grand Arrival effects and display what Grand Arrival does on its tooltip
• a82a6f7d - Rework Summon Control
• 5b8c9c36 - Remove Combat Veteran and Combat Techniques from Summoner
• 461669be - Rework less useful Wild Summon effects and slightly adjust Jelly
• 1d7ad8af - Oops
• 0fcf8ae4 - Slightly tweak Summon Control
• 1cf461dc - Bugfix for Frantic Summoning decrementing due to non-nature summons
• 8fed92df - Buffed Resilience and made it more straightforward
• 52f68e40 - Change Rage to be passive and make Nature's Cycle lower Summon Control's cooldown
• 64362197 - Changed spider's grand arrival effect
• 1f8ff800 - Fix Rage working on summon timeout
• a6fc66b8 - Fixed tooltip for Hydra's grand arrival effect
• 8acfc894 - Slightly restructure Detonate effects and add a useful tooltip to Detonate
• 0f0a9e8b - Oops
• afbfbad9 - Should fix both typos, not just one
• f043a824 - Adjusted some of the less useful Detonate effects
• 1de8b266 - Lowered Detonate cooldown
• eb7ced98 - Adjust summon tooltip wording
• 7a6648ea - Made the caller's ego more useful for summoners
• 93118520 - Revert "Revert "Check for conflicts between power source and categories for mastery boosting""
• 593e6330 - Fix Grand Arrival tooltip
• fe3c1a36 - Change Hydra and Golem's Detonate effects
• 092ad42a - Oops
• 8fb4708e - Oops x2
• 0dca84bd - Summons no longer try to kill you when you're frozen
• 8260a3e2 - Typo
• ac087e3d - Adjust golem and rimebark's Wild Summon
• caeb8baf - Description fix
• 51c232ea - Rename Summon Control to Pheromones
• 8cf21dc1 - Update Description
• b10f2b11 - Removed deprecated Detonate effect
• b5234010 - Adjust a few Detonate effect durations
• 0db4152f - Fixed the elements of Hydra's detonate
• 1e3d9fb4 - Tweak Great Caller
• c1a9f84f - Fix Grand Arrival description
• 3e718ef2 - Fix merge conflicts

Added 1 commit:

• 9d00f5fa - Revert "Fix merge conflicts"

Added 2 commits:

• 2d254ebe - Properly fix merge conflicts
• b81e7cfb - Merge branch 'summonerTweaks' of https://git.net-core.org/Bunny/t-engine4 into summonerTweaks

Added 1 commit:

• b538977b - Fix typo

Added 1 commit:

• 9a2a1413 - Fix fire drake hatchlings

Added 1 commit:

• 54e8027b - Fix slow strength display

Added 1 commit:

• fa4dc5e7 - Add stun duration to ritch detonate

Added 1 commit:

• c8fc42a0 - Make summoner start with Mindstar Mastery unlocked

Added 1 commit:

• a9012b00 - Adjust armor value from golem's detonate

Added 1 commit:

• f9c13891 - Revert removing combat techniques from summoner

THat looks neat! But I'm confused by the change:

• if rsrc == target and self ~= target and target:attr("encased_in_ice") and not target.isMySummoner then return -50 end -- summons shouldn't hate each other more than enemies and shouldn't hate their summoner

target.isMySummoner will always exist for any actors and thus this is the same as commenting ou the line; am I missing something ?

Ah, you're right! I was thinking it would have an interaction between summons.
(If you're wondering why I changed it to begin with, summons aggro-ing on their summoner to try and break them out of ice is a nice concept, but in practice does more harm than good when part of the damage doesn't go to the ice and instead damages the summoner. Especially considering it's only -50, so the majority of the time the interaction occurs there aren't any enemies in sight and there's no urgency to be broken out of the ice.)

Added 1 commit:

• cc70d7fb - Summons shouldn't hate their master

Ah good thanks :) Other than that the changes look very cool! Thanks !

Status changed to merged