Skip to content

Remove extra log messages for weapon procs

Chris Davidson requested to merge Shibari/t-engine4:LogFix into master

Removes the ITEM_ damage types from the combat log and touches up some misc numbers and displays on them.

I kept the item proc melee_project damage types out of the combat log for a reason. They are essentially hacky ways of having a special_on_hit variant that can scale its chance and power with how many items have it. It was left in the melee_project table mostly because the stuff I was revising was already there, I was just changing how it worked to be normalized, how it was displayed to convey more information (30 arcane silence? what is that?), and removing the actual damage done in part to clean up the combat log.

Technically this should be its own special proc system, and that should be changed eventually as there are some other consequences of this method that have come up (block damage types, wielder and combat table not summing in intuitive ways). I'm not surprised someone got confused and added these to the logs as it really was a silly way to do it. I don't have time to fix this right now, though.

The display of these effects is already handled by the messages setEffect gives. Putting special combat log entries is the equivalent of putting <20% chance to cast Nova rank 5> in the combat log when making unarmed attacks with Storm Bringer Gauntlets. We only need to display this when the proc goes off, and the engine already handles that. As is, my combat log is completely unreadable.

Merge request reports