Pulls the actual parsing of a hotkey into an icon out into its own function

Modifies `engines\default\engine\HotkeysIconDisplay.lua` to better support addons. The current call to `display()` draws every hotkey over the course of a nested iteration, which means that if someone wishes to modify this behavior (e.g. have flagged talents use a different border color, or support multiple talent icons to denote different states of a talent), the entire `display()` function must be entirely replaced. This isn't ideal as these modifications are mutually exclusive.

This MR splits the actual parsing of a hotkey into a `displayHotkey()` function (with appropriate arguments) so that addon developers can safely superload the hotkey drawing behavior.

**This MR is save-safe.**

See merge request !691

Fix Purging Trap to check silence immunity.

The silence aspect of the trap will check silence immunity of the target before applying silence.

See merge request !772

Miscs

1. Bring back the fix: The duration of an existing effect will not be reduced by setting a new effect with a shorter duration (controlled by on_merge for some  effects).
2. Living lightning correctly works with Range Amplification Device
3. Stormshield rune's block number and threshold should be an integer
4. Randart bows & slings should not have base damage

See merge request !771

Update Aura of Undeath description

Update Aura of Undeath description to specify that the inherited damage increase is based on your *highest* damage increase.

See merge request !770

Update special ego rules to include all cases of talent_on_X.

Fixes issues such as the one which will result from imbuing the Prismatic Eye onto armor with a talent_on_spell e.g. Black Robe.

See merge request !769

Change the type for the Avatar Distant Sun Unlock Checker to "base/class"

Change the type for the Avatar Distant Sun Unlock Checker hidden talent to "base/class" so it will not prevent a Sun Paladin from entering Zigur who otherwise could.

See merge request !768

Update the on_pre_use for Vault to check for a shield only.

The action only uses the shield, so we don't need to check for sling and ammo as well.

See merge request !767

Fix Call of the Ooze on_pre_use

Update Call of the Ooze on_pre_use to check your number of total summons vs the limit allowed by Mitosis (Call of the Ooze's own limit is still checked in the action), so it can be used if you already have one or more oozes but do not have max summons or the max oozes allowed by mitosis.

See merge request !766

Correct Vim tooltip.

Vim gain is 1 + 50% Wil times creature rank, not 1 + 30% Wil times half creature rank

See merge request !762

Allow Waters of Life to bypass is_heal test

Allow Waters of Life to bypass is_heal test because it prevents poison/disease from hurting you, even if 0 heal mod stops any healing.

See merge request !760

Update Aura of Undeath description to specify that the inherited damage increase is based on your highest damage increase.

Bring back the fix: The duration of an existing effect will not be reduced by setting a new effect with a shorter duration (controlled by on_merge for some  effects). This means that an effect will not be removed if you save against another application of the same effect.
This was not functioning due to a careless code removal.

Update special ego rules to include all cases of talent_on_X. Fixes issues such as the one which will result from imbuing the Prismatic Eye onto armor with a talent_on_spell e.g. Black Robe.

Change the type for the Avatar Distant Sun Unlock Checker to "base/class" so it will not prevent a Sun Paladin from entering Zigur who otherwise could.

Update the on_pre_use for Vault to check for a shield only. The action only uses the shield, so we don't need to check for sling and ammo as well.

Update Call of the Ooze on_pre_use to check your number of total summons vs the limit allowed by Mitosis (Call of the Ooze's own limit is still checked in the action), so it can be used if you already have one or more oozes but do not have max summons or the max oozes allowed by mitosis.

Correct Vim tooltip. (Vim gain is 1 + 50% Wil times creature rank, not 1 + 30% Wil times half creature rank)

Allow Waters of Life to bypass is_heal test because it can also cleanse effects which could possibly reduce your heal mod to 0 (causing the is_heal test to fail).

Prevent Heroism lost life bonus from chaining infinitely.



See merge request !757

Shield effect subtype consolidation

1. Limit "shield" effect subtype to effects with a limited damage absorption amount (magical shields affected by getShieldAmount() etc, Psi Damage Shield, and Resonance Shield). Removed subtype from many effects that are not impacted by getShieldAmount, getShieldDuration, or that grant other types of protection, such as damage redirection, damage negation, negative life, and so on.
2. Clarify that only one shield is removed and chosen at random for Shattering Blow, Sunder Armour and Impale.

See merge request !754

Update Weapon of Light description to include the shield duration refresh.



See merge request !752

Fix typo in action speed tooltip and update block tooltip

Fix typo in action speed tooltip (performa -> perform) and update block tooltip to reflect current behavior.

See merge request !751

Typo fix Call of the Mausoleum: lyring -> lying



See merge request !746

Typo fix Gravitic Trap: damgae -> damage



See merge request !745

Makes combat tables for items refer back to their source item.

Adds a `self` property to `o.combat` and `o.special_combat` that refers back to item's full table. Combat tables tend to get passed around through various functions and callbacks and it can be difficult to connect a combat table to a full object. This makes the link two-way (`o.combat.self == o`).

This doesn't break saves, but any functionality dependent on the link *will* require a new save, as it only applies to newly generated items.

See merge request !693

Prevent clicking multiple times on hotkeys while the targetting interface is running (prevents infinite ressource bug)