• This project
    • Loading...
  • Sign in

tome / Tales of MajEyal · Merge Requests

GitLab

  • Go to group
  • Project
  • Activity
  • Files
  • Commits
  • Builds 0
  • Graphs
  • Milestones
  • Merge Requests 43
  • Labels
  • Forks
  • Snippets
  • Network
Open
MR Merge Request !813 opened
2021-10-28 13:36:12 UTC by yutio888 @yutio888

move soul leech into others, since this is very frequently applied

and removing it is of no use at all.

Edited 2022-01-26 18:50:53 UTC
Check out branch Download as
  • Email Patches
  • Plain Diff
Request to merge yutio888:soul_leech_others into master (66 commits behind)
×

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://git.net-core.org/yutio888/t-engine4.git soul_leech_others
git checkout -b yutio888/t-engine4-soul_leech_others FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git checkout master
git merge --no-ff yutio888/t-engine4-soul_leech_others

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines

CI build passed for 196059da. View details
CI build skipped for 196059da. View details
CI build canceled for 196059da. View details
CI build failed for 196059da. View details
CI build running for 196059da. View details
CI build pending for 196059da. View details

Ready to be merged automatically

Ask someone with write access to this repository to merge this request.

  • Discussion 3
  • Commits 1
  • Builds 0
  • Changes 2
  • DarkGod
    @darkgod commented 2021-10-29 08:19:21 UTC

    Not sure I understand why ?

  • yutio888
    @yutio888 commented 2021-10-29 08:29:53 UTC

    Because Soul Leech is a very disturbing nuisance when you want to cleanse magical debuffs, and nec npcs may have many magical debuffs that are more deadly: Bane of confusion/blindness, Impending Doom, Hexes from dread, etc. Wild infusion and shatter affliction rune can clear only one magical debuff at once, and Soul Leech makes these common tools much less reliable against necs. Besides, Soul leech provides soul upon cleanse, which means removing it is somewhat benificial to necs and not good for the victims.

    Edited 2021-10-29 08:35:14 UTC
  • Please register or login to post a comment
813 of 846
Prev Next
Assignee
No assignee
Assign to
No
Milestone
None
Assign milestone
0
Labels
None
Assign labels
  • View labels
3
3 participants
Reference: tome/t-engine4!813