(for 1.8) add power vs save description for talents
Currently, power vs save mechanism is not explained in game, and players can only tell which power/save the specific talent is using for debuff/knockback/... by experience or diving into the code. This merge request add more details in the descriptions of talents, in the form like (Physical Power vs Mental Save). Some helper functions are also provided in DescHelper.lua.
Besides, some minor bugs have been fixed, most of which are inappropriate power used in complex damage type. Higher draconic T1 is worth noting that it contains 5 damage types, each one uses a slightly difference power. This merge request changes that to use physical power & mindpower, whichever is larger.
Note: This merge request changes many files and brings much work for translation. Besides, I currently have no access to dlcs' repo, and the work for dlcs' talents description might need to be done by someone with the access.
-
Desc.vs(Desc.pp, Desc.ps)
looks a bit cumbersome to write, what aboutDesc.vs("pp", "ps")
or even could shorten it toDesc.vs("p", "p")
(while keepingDesc.vs("pp", "ps")
valid syntax too for strange cases like power vs power or whatever). We coudl even have an even shorter syntax for the most common cases:Desc.vs"pp"
-
The simplified syntax seems fine, and I'll try make it. But it suddenly occurs to me, what is the proper abbreviation of steampower? Of course, steampower cannot be shortened as "ss" or "s", which is already used by spellpower. Maybe we could use "t" / "st" or something else?
-
Added 1 commit:
- 44f393fc - typo
-
Added 23 commits:
-
44f393fc...905a4a6d - 22 commits from branch
tome:master
- 94bde388 - Merge remote-tracking branch 'upstream/master' into power_vs_save_desc
-
44f393fc...905a4a6d - 22 commits from branch
-
Added 1 commit:
- 252b69d4 - add description in cross tier effects of how it is applied
-
Added 1 commit:
- 1e15d6da - fix ICE damage type
-
Added 1 commit:
- 3906b7a3 - fix Ice storm & Glacial Vapour damage type
-
mentioned in commit 9b214c3c
-
Please register or login to post a comment