tome / Tales of MajEyal · Merge Requests

Title changed from add power vs save description for talents to (for 1.8) add power vs save description for talents

Desc.vs(Desc.pp, Desc.ps) looks a bit cumbersome to write, what about Desc.vs("pp", "ps") or even could shorten it to Desc.vs("p", "p") (while keeping Desc.vs("pp", "ps") valid syntax too for strange cases like power vs power or whatever). We coudl even have an even shorter syntax for the most common cases: Desc.vs"pp"

oh and you have access to the DLCs now :)

The simplified syntax seems fine, and I'll try make it. But it suddenly occurs to me, what is the proper abbreviation of steampower? Of course, steampower cannot be shortened as "ss" or "s", which is already used by spellpower. Maybe we could use "t" / "st" or something else?

Hum, just use "t" for steam power, but it means Desc class needs to be superloaded from embers to define it

Added 4 commits:

• eb237159 - rework DescHelper to make syntax much simpler
• 98ffc5a1 - simplified DescHelper
• 5cf8033c - remove unused params in DescHelper
• 2dfebdd6 - adjust some talents' description

The main part is done, I've checked most setEffect/checkHit usage in talents. There should be some bypass-save effects not described specifically, which should be fine, I'll do it later and add description for DLCs first.

Added 1 commit:

• 44f393fc - typo

Added 23 commits:

• 44f393fc...905a4a6d - 22 commits from branch tome:master
• 94bde388 - Merge remote-tracking branch 'upstream/master' into power_vs_save_desc

Added 1 commit:

• 252b69d4 - add description in cross tier effects of how it is applied

Added 1 commit:

• 1e15d6da - fix ICE damage type

Added 1 commit:

• 3906b7a3 - fix Ice storm & Glacial Vapour damage type

Status changed to merged

mentioned in commit 9b214c3c