Otowa Kotori / Tales of MajEyal · Commits

Update tooltips and descriptions for crit shrug.

1)Update Crit Shrug Off tooltip for current behavior.
2)Update Crit Reduction tooltip to use wording more consistent with other tool tips.
3)Update Indiscernible Anatomy description for Crit Shurg behavior.
4)Change 'wounds' to 'cuts' in immunity description to clarify the effect.

See merge request !791

Refactor melee hit proc

1. add two callbacks: callbackOnMeleeProject used for effects similar to melee-project and should be triggered before weapon's on-kill effects; callbackOnMeleeHitProcs used by the victim to trigger on-hit effects
2. move many melee procs in attackTargetHitProcs into related talents/effects by callback and thus greatly simplify this function
3. remove the obselete attributes "damage_backfire","movespeed_on_hit"
4. remove several unique talent attributes "shattering_impact", "knockback_on_hit", "onslaught"
5. slightly reorders the proc order, which should not make much difference though.

See merge request !789

Make sure Aeryn is successfully made before we try to add her

Make sure Aeryn is successfully made before we try to add her (prevents the game from hanging if you return to high peak 10 post-win).

See merge request !788

Update Jumpgate to provide more information for the teleports

Update Jumpgate to provide more information for the teleports (range, cost, cooldown). Also makes the cooldown of the two sustains consistent.

See merge request !787

fix occasionally Multicaster is triggered more than twice per turn

it occurs when spell triggered by Multicaster triggers a new beam by talent_on_spell.

See merge request !784

fix summoned wild war hounds usually do not sustain total thuggery at birth



See merge request !786

fix: makes sure charactersheet display all of NPC's inscriptions

since NPCs do not care about inscription slots, they only display the first three runes before.

See merge request !785

1.7.5 Miscellaneous fixes.

 * FIX: Bullseye now affects more than 0 talents at rank 1.
 * FIX: Collapse can no longer trigger instant critical hits.
 * FIX: Self-Judgement applies against damage from effects, such as Greater Weapon Focus.
 * FIX: Taint of Purging is marked as a quest item like all other alchemist rewards.
 * BALANCE: Change Blood Rush’s bleed calculation to work the same as Blood Bath and Scoundrel.  Lowered bleed multiplier.
 * POSSIBLE FIX: Simplify green no_healing shader check.  Since 0 healing is a yes/no thing, there is no need for old_healwarn
 * QOL: Changed Rockwalk's targeting to not auto-accept because it is a movement skill.

See merge request !783

Revise Conveyance

1. slightly reduce the mana cost of Phase Door, it's somewhat too much for a basic mobility talent;
2. remove the 35% failure rate of teleport, increase the mana cost, cooldown and reduce accuracy instead;
3. makes it possible to open vaults while Probability Travel is sustained

btw, makes Body of Stone not break when bumping to attack others.

See merge request !782

Fix Radiance's lite radius should be integer



See merge request !781

Revise Cleansing Flames

1. makes it instant to compensate the loss of passive mode, and the opportunity to remove several debuffs per turn;
2. rewrite the formula of cleanse chance each turn, to use actual talent level instead of raw level and reduce the cleanse chance beyond player's talent level;
3. makes it dealing as much damage as the description says, currently it deals a fixed 10 damage. 

If this is rejected, then the part 3 might need a standalone fix.

See merge request !780

fix Adept & talents_mastery_bonus not updating passives on change

fix talents_mastery_bonus not updating passives on change by wearing/taking off Radiance and Ring of the War Master
fix Adept not updating passives on learn

See merge request !778

fix on_added_to_level not triggerred in special cases

sometimes we see random alchemists without golems, now we found why

See merge request !777

fix brawler randbosses on certain monster types having very high weapon damage

resolvers.levelup is handled before applyRandomClass, so the levelup part is not replaced currently.
Manually remove the levelup part to fix it.

See merge request !776

Fix Hydra's Bite correctly selects up to two nearby foes

Currently Hydra's Bite is very likely to hit only one target even if there are two foes nearby.

See merge request !775

Update the description of Counterstrike to show the value of the Defense reduction.

Also: Adds that a ranged weapon attack will also deal double damage. Adds a default power parameter as a failsafe for the desc. 

See merge request !773

Update Lichform quest with on_grant to check for Celia complete.

Allows Adventurers in AoA to complete the Lichform quest if they kill Celia before gaining it. Checks if grave-necromancer quest is done and completes the 'heart' objective onTickEnd if so.

See merge request !764

Faster!

This merge request consists of several independent commits which aim at making ToME4 faster:
1. Add cache for particles & shaders to avoid loadfile & loadstring in game;
2. Adjust the record of recent logs, making it faster and takes less space under extreme situation; 
3. Add cache for ShowChatLog dialog, making the scrolling smoother;
4. Reduce the frequency of player's 'hit_warning' particle effects, which might spam too much (each damage number may create a particle effect).

See merge request !749

Modify Step Up

## Change
1. Each kill provides a 2-turn buff that gives 1000% movement speed in several moves, and any action other than moving will remove the buff.

## Reasons
1. Removes raw talent level usage & removes old-fashioned callback in Actor.lua
2. Makes Step Up more predictable and reliable, that no matter how much energy you have (which you cannot know in-game), you'll always benefit from Step Up and do not need to guess the remaining steps you could make.
3. Talent level above 5 gives small bonus

See merge request !744

FOR1.8: Update Disintegration. Change proc tracking from callbackOnActBase to a turn_pro…

…c, fix call to removeEffectsFilter, restore tracking The Cure achievement.

See merge request !736

(for 1.8) add power vs save description for talents

Currently, power vs save mechanism is not explained in game, and players can only tell which power/save the specific talent is using for debuff/knockback/... by experience or diving into the code.
This merge request add more details in the descriptions of talents, in the form like (Physical Power vs Mental Save).
Some helper functions are also provided in DescHelper.lua.

Besides, some minor bugs have been fixed, most of which are inappropriate power used in complex damage type. 
Higher draconic T1 is worth noting that it contains 5 damage types, each one uses a slightly difference power. This merge request changes that to use physical power & mindpower, whichever is larger.

Note: This merge request changes many files and brings much work for translation. Besides, I currently have no access to dlcs' repo, and the work for dlcs' talents description might need to be done by someone with the access.

See merge request !758

Pulls the actual parsing of a hotkey into an icon out into its own function

Modifies `engines\default\engine\HotkeysIconDisplay.lua` to better support addons. The current call to `display()` draws every hotkey over the course of a nested iteration, which means that if someone wishes to modify this behavior (e.g. have flagged talents use a different border color, or support multiple talent icons to denote different states of a talent), the entire `display()` function must be entirely replaced. This isn't ideal as these modifications are mutually exclusive.

This MR splits the actual parsing of a hotkey into a `displayHotkey()` function (with appropriate arguments) so that addon developers can safely superload the hotkey drawing behavior.

**This MR is save-safe.**

See merge request !691

1. add two callbacks: callbackOnMeleeProject used for effects similar to melee-project and should be triggered before weapon's on-kill effects; callbackOnMeleeHitProcs used by the victim to trigger on-hit effects
2. move many melee procs in attackTargetHitProcs into related talents/effects by callback and thus greatly simplify this function
3. remove the obselete attributes "damage_backfire","movespeed_on_hit"
4. remove several unique talent attribute "shattering_impact", "knockback_on_hit", "onslaught"
5. slightly reorders the proc order, which should not make much difference though.

… hanging if you return to high peak 10 post-win).

…down). Also makes the cooldown of the two sustains consistent.

…, since monsters do not care inscription slots, they only display the first three runes before.

…en spell triggered by Multicaster triggers a new beam by talent_on_spell.

1. slightly reduce the mana cost of Phase Door, it's somewhat too much for a basic mobility talent;
2. remove the 35% failure rate of teleport, increase the mana cost, cooldown and reduce accuracy instead;
3. makes it possible to open vaults while Probability Travel is sustained

btw, makes Body of Stone not break when bumping to attack others

Simplify green_screen shader check
Change Blood Rush’s bleed calculation to work the same as Blood Bath and Scoundrel.  Lowered bleed multiplier.
Fixed scaling of Bullseye so that it affects more than 0 talents.
Fix Collapse triggering critical hits even if it was aimed so that it couldn’t be cast.
Self-Judgement applies against damage from effects, such as Greater Weapon Focus.
Taint of Purging is marked as a quest item like all other alchemist rewards.